Improved multi-node multi-GPU random forests. #4238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
canonizer
commented
Mar 8, 2019
canonizer
commented
- removed rabit::Broadcast() from each invocation of column sampling
- instead, syncing the PRNG seed when a ColumnSampler() object is constructed
- this makes non-trivial column sampling significantly faster in the distributed case
- refactored distributed GPU tests
- added distributed random forests tests
- removed rabit::Broadcast() from each invocation of column sampling - instead, syncing the PRNG seed when a ColumnSampler() object is constructed - this makes non-trivial column sampling significantly faster in the distributed case - refactored distributed GPU tests - added distributed random forests tests
RAMitchell
reviewed
Mar 8, 2019
There was a problem hiding this comment.
I don't think it's necessary for us to have a separate folder distributed-gpu, these tests can just go in the distributed folder. I have been meaning to do the same with python tests. This folder structure was only an artefact of running tests using nose, which we don't use any more.
| # Notify the tracker all training has been successful | ||
| # This is only needed in distributed training. | ||
| xgb.rabit.finalize() | ||
| import distributed_gpu as dgpu |
There was a problem hiding this comment.
I think these python files can be combined into a single file using command line arguments to configure the test.
RAMitchell
approved these changes
Mar 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.