Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix javadoc warnings and set failOnError and failOnWarning to true #95

Merged

Conversation

sclassen
Copy link
Contributor

Now all Javadoc comments are OK and the build can be configured to fail if new warnings/errors are introduced.

Feel free to reject this PR if you prefer not to be forced to follow exactly the Javadoc rules 😉

@martinfrancois
Copy link
Contributor

We absolutely should, thanks! 😊

@martinfrancois martinfrancois merged commit 0c1469b into dlsc-software-consulting-gmbh:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants