-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically select first subcategory if a category is empty #86
Automatically select first subcategory if a category is empty #86
Conversation
Hi @ArvidNy |
I was just having a look through the PR... I have to say that while I see that it would make sense to skip empty categories entirely, even when selecting ones from the I would propose: What if we just refactor the But I do agree that we should do something about the empty categories in general, since I agree it's not ideal (but I think this discussion would be something for a different issue & PR). |
Sure, I can see that it might be confusing to some users that the main category will not open. We could of course revert the changes I made when clicking the breadcrumb and a category item and only make it behave this way if the default category is empty. That would still allow you to manually open the category and see that it is empty but it wouldn't be the first thing you see. As for a method for setting the default category, I do agree that it would be very usable too. |
Fix code style issues
…m/ArvidNy/PreferencesFX into select-first-subcategory-if-empty
This would also be a possibility. I would be okay with that! |
Great, then I'll leave this PR open for you to merge - it think I've finally sorted out all the style issues now. If I find some spare time in the future I might open a new PR for setting the default category as well, but don't count on it as it looks now. So feel free to implement it yourself if you want to! |
Thanks a lot! Looks good now, will merge it after the second check passed and will make a release |
Thanks for your contribution! |
Fixes #83