Fix progress bar doubling #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mllwchrry
commented
Sep 9, 2024
•
mllwchrry
commented
- Since this PR suggests a bug fix, the relevant tests have been added.
- Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
- This PR is just a minor change, like a typo fix.
Arvolear
added a commit
that referenced
this pull request
Sep 9, 2024
* Add zkit scope supporting (#20) * Add zkit scope supporting * Fix run scope tasks * Fix task name in generateVerifiers function * Bump zkit version (#21) * Bump zkit version * Update zkit package version and add Vyper verifiers support * Fix typo * Feature/circom parser (#22) * Add zkit scope supporting * Fix run scope tasks * Base integration with circom-parser * Move to zod and integrate circom-parser with cache logic * Add logs and small fixes * Add circuit signals info to the artifacts * Integrate with new zktype package version * Update parser files structure * Remove Intermediate signals from artifacts * Add unit test * Update package versions * Fix circom-parser imports name * Update Reporter messages * Compiler management (#23) * Added compiler management * test fix * made some fixes, added compilerVersion to config * circom-parser version updated * refactoring * 2nd round of refactoring * 3rd round of refactoring * 4th round of refactoring * Config structure and factory singleton changes (#24) * modifier config structure and factory singleton approach * zktype version updated * Reporter refactoring (#25) * facade implementation of the reporter * refactoring * quick readme fix * package-lock * fix test * fixes and pretty * circom-parser version updated * fixed errors in resolver * Fix progress bar doubling (#28) * made ProgressBarProcessor and SpinnerProcessor singleton * pretty log --------- Co-authored-by: Artem Chystiakov <artem.ch31@gmail.com> --------- Co-authored-by: Oleg Komendant <44612825+Hrom131@users.noreply.github.com> Co-authored-by: Mllw Chrry <mariia.zhvanko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.