Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Adds pre-commit and just lint task #138

Merged
merged 4 commits into from
Jul 15, 2023
Merged

Conversation

jefftriplett
Copy link
Member

TODO: Add pyproject.toml before we merge it and probably hold off until the bulk of Drew's schedule work is ready.

I have had this locally for a while but never pushed it. It needs a pyproject.toml to complete it and probably some minor changes to that it doesn't try to change everything.

I'll probably backport it to the last few years once it's ready.

@jefftriplett jefftriplett marked this pull request as draft July 14, 2023 18:35
Copy link
Collaborator

@drewbrew drewbrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the concept for sure (if not the ancient python version 😆 )

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Co-authored-by: Drew Winstel <drewbrew@users.noreply.github.com>
@jefftriplett jefftriplett marked this pull request as ready for review July 15, 2023 14:18
@jefftriplett jefftriplett changed the title WIP: ⚙️ Adds pre-commit and just lint task ⚙️ Adds pre-commit and just lint task Jul 15, 2023
@jefftriplett
Copy link
Member Author

TODO: Add pyproject.toml before we merge it and hold off on running lint until @drewbrew's work is done.

@jefftriplett jefftriplett merged commit 54b7c6f into main Jul 15, 2023
@jefftriplett jefftriplett deleted the adds-pre-commit branch July 15, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants