Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore new data coming from Adyen #17

Merged
merged 1 commit into from
Sep 24, 2015
Merged

Conversation

maiksprenger
Copy link
Member

When we migrated our Adyen account to the new 'systems communications'
interface, we started getting new data, which caused 500s. As all of it
comes in the additionalData.KEY = VALUE format and we don't need it,
we just blanket ignore it for now.

@maiksprenger
Copy link
Member Author

I'm trying to make this Sentry exception (Oscaro employees only) go away. And this "pray it works" PR is the best I can think of.

@@ -60,6 +60,7 @@ class Constants:
SESSION_VALIDITY = 'sessionValidity'
SKIN_CODE = 'skinCode'
SHIP_BEFORE_DATE = 'shipBeforeDate'
ADDITIONAL_DATA = 'additionalData.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like none of the other fields have the trailing .. Can we avoid this inconsistency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rename to ADDITIONAL_DATA_PREFIX as discussed.

When we migrated our Adyen account to the new 'systems communications'
interface, we started getting new data, which caused 500s. As all of it
comes in the 'additionalData.KEY = value' format and we don't need it,
we just blanket ignore it for now.
@Exirel
Copy link
Contributor

Exirel commented Sep 24, 2015

LGTM.

maiksprenger added a commit that referenced this pull request Sep 24, 2015
@maiksprenger maiksprenger merged commit 72c4f17 into master Sep 24, 2015
@maiksprenger maiksprenger deleted the feature/additional-data branch September 24, 2015 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants