make django-oscar-accounts really could work without oscar #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pity it's not merged yet. I had to take entire oscar with my small project. %p |
Current coverage is 68.87% (diff: 39.28%)
|
|
Really a pity this is not merged. I think it would be good for the project as well. This package helps a lot if you want to make your own module based project with recurred billing, where an account is the credit a user has. |
|
I know this is quite old, but if you're able to bring this up to date with master I'm more than happy to review/merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gather rest of what is imported from oscar in a model (compact_oscar.py) and with a simple import check it could fallback to oscar if installed. But in case one use this interesting package alone, there will some replacements to get the oscar-accounts works alone.