Skip to content

Commit

Permalink
fix: ♻️ Corrected the incorrect references for StartingPosition prope…
Browse files Browse the repository at this point in the history
…rty in DynamoDB & kinesisStreams
  • Loading branch information
Anjali Modi authored and KillDozerX2 committed Sep 11, 2023
1 parent 58a836a commit b7cd1e1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/parameters/DynamoDBSourceParameters.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ The number of batches to process concurrently from each shard. The default value
[schema.ts:42](https://github.com/distinction-dev/serverless-pipes/blob/adc1ce1b20b719d2e58f62a01c813e4ef9c57a5c/src/schema.ts#L42)


### startingPosition (optional)
### startingPosition

• **startingPosition**: `string`

Expand Down
6 changes: 2 additions & 4 deletions src/compiler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ export function compileBasedOnSourceType(
case "dynamodb": {
const params: AWSPipesPipePipeSourceParametersDefinition = {
DynamoDBStreamParameters: {
StartingPosition:
config.source[sourceName].parallelizationFactor || "",
StartingPosition: config.source[sourceName].startingPosition || "",
BatchSize: config.source[sourceName]?.batchsize || 10,
DeadLetterConfig: {
Arn: config.source[sourceName]?.deadLetterArn || "",
Expand All @@ -63,8 +62,7 @@ export function compileBasedOnSourceType(
case "kinesisStream": {
const params: AWSPipesPipePipeSourceParametersDefinition = {
KinesisStreamParameters: {
StartingPosition:
config.source[sourceName].parallelizationFactor || "",
StartingPosition: config.source[sourceName].startingPosition || "",
BatchSize: config.source[sourceName]?.batchsize || 10,
DeadLetterConfig: {
Arn: config.source[sourceName]?.deadLetterArn || "",
Expand Down

0 comments on commit b7cd1e1

Please sign in to comment.