Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Premium buttons #10353

Merged
merged 10 commits into from
Jul 4, 2024
Merged

feat: Premium buttons #10353

merged 10 commits into from
Jul 4, 2024

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jun 18, 2024

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jul 4, 2024 6:53pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jul 4, 2024 6:53pm

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 50.48%. Comparing base (9c76bbe) to head (cfb105a).

Files Patch % Lines
packages/builders/src/components/Assertions.ts 76.92% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10353      +/-   ##
==========================================
+ Coverage   50.37%   50.48%   +0.11%     
==========================================
  Files         228      228              
  Lines       20641    20702      +61     
  Branches     1240     1249       +9     
==========================================
+ Hits        10397    10452      +55     
- Misses      10199    10205       +6     
  Partials       45       45              
Flag Coverage Δ
builders 95.78% <84.61%> (-0.13%) ⬇️
formatters 99.33% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite force-pushed the feat/premium-button branch 2 times, most recently from 2670a8f to de3f24a Compare June 18, 2024 18:41
@Jiralite Jiralite marked this pull request as ready for review June 18, 2024 18:42
@Jiralite Jiralite requested review from a team as code owners June 18, 2024 18:42
@Jiralite Jiralite force-pushed the feat/premium-button branch 2 times, most recently from bcfac40 to f1deb6f Compare June 18, 2024 18:45
@Jiralite Jiralite linked an issue Jun 20, 2024 that may be closed by this pull request
@kodiakhq kodiakhq bot merged commit 4f59b74 into main Jul 4, 2024
8 checks passed
@kodiakhq kodiakhq bot deleted the feat/premium-button branch July 4, 2024 18:57
@vladfrangu vladfrangu added this to the discord.js 14.16 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

New Premium Button Style & Deep Linking URL Schemes
6 participants