Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GuildBanManager): Add bulkCreate() method #10182

Merged
merged 1 commit into from Apr 2, 2024
Merged

feat(GuildBanManager): Add bulkCreate() method #10182

merged 1 commit into from Apr 2, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 19, 2024 •
edited by ghost
Loading

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

@ghost ghost self-requested a review as a code owner March 19, 2024 11:25
@ghost ghost requested review from vladfrangu, iCrawl, kyranet and SpaceEEC March 19, 2024 11:25
@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2024 9:21am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2024 9:21am

GoldenAngel2
GoldenAngel2 suggested changes Mar 19, 2024
View reviewed changes
packages/discord.js/src/structures/Guild.js Outdated Show resolved Hide resolved
packages/discord.js/src/structures/Guild.js Outdated Show resolved Hide resolved
packages/discord.js/src/structures/Guild.js Outdated Show resolved Hide resolved
packages/discord.js/src/structures/Guild.js Outdated Show resolved Hide resolved
@ghost ghost requested a review from GoldenAngel2 March 19, 2024 13:54
@ghost ghost changed the title feat(Guild): Add bulkBan() method feat(GuildBanManager): Add bulk() method Mar 19, 2024
@ghost ghost requested a review from GoldenAngel2 March 19, 2024 16:46
@jaw0r3k
Copy link
Contributor

jaw0r3k commented Mar 19, 2024 •
edited
Loading

the users field is always required so it would be better to make it a separate parameter

@ghost ghost requested a review from jaw0r3k March 19, 2024 19:17
@ghost ghost requested a review from sdanialraza March 20, 2024 05:47
@ghost ghost changed the title feat(GuildBanManager): Add bulk() method feat(GuildBanManager): Add bulkCreate() method Mar 20, 2024
vladfrangu
vladfrangu previously requested changes Mar 20, 2024
View reviewed changes
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
almeidx
almeidx requested changes Mar 20, 2024
View reviewed changes
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
@ghost ghost requested review from almeidx and vladfrangu March 20, 2024 13:48
Qjuh
Qjuh suggested changes Mar 20, 2024
View reviewed changes
packages/discord.js/src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
@ghost ghost requested a review from Qjuh March 20, 2024 20:20
almeidx
almeidx requested changes Mar 21, 2024
View reviewed changes
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/errors/Messages.js Outdated Show resolved Hide resolved
packages/discord.js/src/errors/ErrorCodes.js Outdated Show resolved Hide resolved
packages/discord.js/src/errors/ErrorCodes.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
@ghost ghost requested a review from almeidx March 21, 2024 18:41
almeidx
almeidx requested changes Mar 21, 2024
View reviewed changes
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
@ghost ghost requested a review from almeidx March 22, 2024 09:12
@AlexEKinney AlexEKinney mentioned this pull request Aug 19, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 19, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 19, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 20, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 20, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 20, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 20, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 21, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 21, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 21, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 22, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 22, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Aug 22, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 22, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 28, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 29, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Sep 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 2, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 2, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 2, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 2, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@GoldenAngel2 GoldenAngel2 Awaiting requested review from GoldenAngel2

@jaw0r3k jaw0r3k Awaiting requested review from jaw0r3k

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

@NotSugden NotSugden Awaiting requested review from NotSugden

@sdanialraza sdanialraza Awaiting requested review from sdanialraza

@Qjuh Qjuh Awaiting requested review from Qjuh

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
api support packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js 14.15
Development

Successfully merging this pull request may close these issues.
10 participants
@jaw0r3k @vladfrangu @kyranet @SpaceEEC @NotSugden @almeidx @GoldenAngel2 @Qjuh @sdanialraza @Jiralite