build: move to ESM and update chalk #6441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiralite
reviewed
Sep 19, 2023
tsconfig.json
Outdated
| "rootDir": "./", | ||
| "module": "ES2022", | ||
| "moduleResolution": "Node", |
There was a problem hiding this comment.
NodeNext is the recommendation for modern projects, which I assume this is.1
Footnotes
There was a problem hiding this comment.
Thanks for the tip!
shaydewael
pushed a commit
to Jupith/discord-api-docs
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6417 is failing because it looks like the latest version of chalk requires ESM. I updated this to be an ESM package, cleaned up some unneccessary tsconfig, and validated the import into the dev portal still works. It seems to be ok?