Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands: fix test asserts #1425

Merged
merged 1 commit into from
Oct 3, 2023
Merged

commands: fix test asserts #1425

merged 1 commit into from
Oct 3, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Oct 3, 2023 •
edited
Loading

This PR fixes the commands test. It reverses passed parameters to the assert.Equal according to the signature (actual after expected):

func Equal(t TestingT), expected, actual interface{}, msgAndArgs ...interface{}) bool

Additionally, the PR replaces assert.Error(t, test.err, err) with assert.Equal(t, test.err, err).

@alexandear alexandear changed the title commands: reverse actual and expected values in asserts commands: fix test asserts Oct 3, 2023
andrewsomething
andrewsomething approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another great contribution! 💙

@andrewsomething andrewsomething merged commit 68b97c8 into digitalocean:main Oct 3, 2023
6 checks passed
@alexandear alexandear deleted the commands-reverse-actual-expected branch October 4, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @andrewsomething