Upgrade administration frontend dependencies #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxammann
requested review from
michael-markl and
steffenkleinle
as code owners
|
I also had to keep graphql on version 15.8 because the "apollo" tooling package is not yet compatible with the new version |
michael-markl
approved these changes
Feb 19, 2022
Comment on lines
+55
to
68
| <Route path={"/"} element={<div | ||
| style={{display: 'flex', alignItems: 'center', flexDirection: 'column'}}> | ||
| <H3>Wählen Sie eine Aktion aus:</H3> | ||
| <NavLink to={"/applications"}><Button style={{ marginBottom: '10px'}} icon="form" text="Eingehende Anträge"/></NavLink> | ||
| <NavLink to={"/eak-generation"}><Button icon="people" text="Karten erstellen"/></NavLink> | ||
| </div> | ||
| </Route> | ||
| <Route exact path={"/applications"}> | ||
| <ApplicationsController token={authData.token}/> | ||
| </Route> | ||
| <Route path={"/eak-generation"}> | ||
| <GenerationController/> | ||
| </Route> | ||
| <NavLink to={"/applications"}><Button style={{marginBottom: '10px'}} | ||
| icon="form" | ||
| text="Eingehende Anträge"/></NavLink> | ||
| <NavLink to={"/eak-generation"}><Button icon="people" | ||
| text="Karten erstellen"/></NavLink> | ||
| </div>}/> | ||
| <Route path={"/applications"} | ||
| element={<ApplicationsController token={authData.token}/>}/> | ||
| <Route path={"/eak-generation"} element={<GenerationController/>}/> | ||
| </Routes> | ||
| </Main> |
There was a problem hiding this comment.
Why did you remove the exact flags for Route /applications and /?
There was a problem hiding this comment.
its no longer supported, should still work, at least from my tests
Comment on lines
+75
to
79
| usePrompt("Falls Sie fortfahren, werden alle Eingaben verworfen.", cardCreationModels.length !== 0); | ||
|
|
||
| return ( | ||
| <> | ||
| <Prompt message={"Falls Sie fortfahren, werden alle Eingaben verworfen."} | ||
| when={cardCreationModels.length !== 0}/> | ||
| <ButtonBar stickyTop={0}> |
There was a problem hiding this comment.
Why are react routing libraries so shitty and unstable...
There was a problem hiding this comment.
My words...
Loving Flutter/Angular for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly I failed upgrading react-scripts. It still has rough edges and fixes are not released yet