Do not filter locations which do not have coordinates #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenkleinle
requested review from
maxammann and
michael-markl
as code owners
steffenkleinle
changed the title
backend/src/main/kotlin/app/ehrenamtskarte/backend/stores/importer/steps/Sanitize.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/stores/importer/steps/Store.kt
Show resolved
Hide resolved
michael-markl
approved these changes
Jan 18, 2022
maxammann
approved these changes
Jan 19, 2022
steffenkleinle
commented
Jan 20, 2022
| @@ -1,59 +0,0 @@ | |||
| package app.ehrenamtskarte.backend.stores.importer | |||
There was a problem hiding this comment.
Moved to PreSanitizeFilter (previously Filter)
steffenkleinle
commented
Jan 20, 2022
| @@ -1,21 +0,0 @@ | |||
| package app.ehrenamtskarte.backend.stores.importer.steps | |||
There was a problem hiding this comment.
Renamed to PreSanitizeFilter
Done |
michael-markl
approved these changes
Jan 20, 2022
|
I had to restart the CI from a failed state... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #443
This currently has no effect since there is only one store with no coordinates (and all other required attributes set):
It is not possible to get correct coordinates here since the street and plz are those of a Postfach:
So the store is only filtered out in a different place. I think I'd merge this anyway as this may change over time and it does not hurt. If no coordinates are found we just filter it out later on.