Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1381: Make name comparison more robust #1559

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

steffenkleinle
Copy link
Member

Short description

Make name comparison more robust.

Proposed changes

  • Use normalize-strings
  • Trim whitespaces before comparing
  • Remove special characters before comparing

Side effects

None.

Resolved issues

Fixes: #1381.

@steffenkleinle steffenkleinle force-pushed the 1381-comparison-applicant-contact branch from 19b5264 to b2716ab Compare August 2, 2024 13:33
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@steffenkleinle steffenkleinle merged commit b7b2ef0 into main Aug 5, 2024
1 check passed
@steffenkleinle steffenkleinle deleted the 1381-comparison-applicant-contact branch August 5, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strip spaces around names before comparison
2 participants