663: Protect pw reset mail #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1sh1918
requested review from
steffenkleinle,
ztefanie and
seluianova
as code owners
f1sh1918
changed the title
...ain/kotlin/app/ehrenamtskarte/backend/auth/webservice/schema/ResetPasswordMutationService.kt
Show resolved
Hide resolved
...ain/kotlin/app/ehrenamtskarte/backend/auth/webservice/schema/ResetPasswordMutationService.kt
Outdated
Show resolved
Hide resolved
f1sh1918
force-pushed
the
663-protect-pw-reset-mail
branch
from
29ea8c8
to
fd95557
Compare
michael-markl
approved these changes
Jul 3, 2024
...ain/kotlin/app/ehrenamtskarte/backend/auth/webservice/schema/ResetPasswordMutationService.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/app/ehrenamtskarte/backend/auth/webservice/schema/ResetPasswordMutationService.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/app/ehrenamtskarte/backend/auth/webservice/schema/ResetPasswordMutationService.kt
Outdated
Show resolved
Hide resolved
…vice/schema/ResetPasswordMutationService.kt Co-authored-by: Michael Markl <marklmichael98@gmail.com>
…vice/schema/ResetPasswordMutationService.kt Co-authored-by: Michael Markl <marklmichael98@gmail.com>
…vice/schema/ResetPasswordMutationService.kt Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Since password reset is not behind a login and can be triggered easily, this api interactions should be protected
Proposed changes
Side effects
Resolved issues
Fixes: #663
related to : https://git.tuerantuer.org/DF/salt/pulls/187