Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1498 add component tests for flutter #1505

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

seluianova
Copy link
Contributor

@seluianova seluianova commented Jun 25, 2024

Short description

  • introduce flutter component testing
  • add tests for favorites page
  • add mocktail to dev dependencies for mocks creation

I have also included my attempt to fix an exception from #1312, but it didn't solve the issue. however, the 'await' was really missing, so I commited that change anyway

Side effects

No

Resolved issues

Fixes: #1498

@seluianova seluianova linked an issue Jun 25, 2024 that may be closed by this pull request
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice pr. Testing suite works great.
Just some minor suggestions for test description to make clear what will be tested. (optional)

frontend/test/favorites/favorites_page_test.dart Outdated Show resolved Hide resolved
frontend/test/favorites/favorites_page_test.dart Outdated Show resolved Hide resolved
@seluianova seluianova merged commit 5cd0244 into main Jul 2, 2024
1 check passed
@seluianova seluianova deleted the 1498-add-component-tests-for-flutter branch July 2, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add component tests for Flutter
3 participants