Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1465: Replace requirements link #1477

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Jun 4, 2024

Short description

The link for the requirements of the EC changed

Proposed changes

  • replace the link

Resolved issues

Fixes: #1465

Testing

  1. http://localhost:3000/beantragen
  2. type in personal data and go next
  3. Check the link above "Blaue Ehrenamtskarte" -> "hier einsehen" for the requirements

Copy link
Contributor

@seluianova seluianova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand why, but if I click 'hier ansehen' in production form
(https://bayern.ehrenamtskarte.app/beantragen), the opened link is really broken:
https://www.ehrenamt.bayern.de/vorteile-wettbewerbe/index.php/ehrenamtskarte/voraussetzungen/index.php

So I'm not sure if adding “index.php#sec3” would fix that.

But this problem is not reproduced locally, the opened link works (with and without "index.php#sec3").

Do you know why the link is corrupted in the prod?

@f1sh1918
Copy link
Contributor Author

f1sh1918 commented Jun 5, 2024

I don't quite understand why, but if I click 'hier ansehen' in production form (https://bayern.ehrenamtskarte.app/beantragen), the opened link is really broken: https://www.ehrenamt.bayern.de/vorteile-wettbewerbe/index.php/ehrenamtskarte/voraussetzungen/index.php

So I'm not sure if adding “index.php#sec3” would fix that.

But this problem is not reproduced locally, the opened link works (with and without "index.php#sec3").

Do you know why the link is corrupted in the prod?
@seluianova we didn't release for a while on prod and in the meantime we adjusted the link once, and now we added an anchor

Copy link
Contributor

@seluianova seluianova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we didn't release for a while on prod and in the meantime we adjusted the link once, and now we added an anchor

ah, okay. good to go then :)

@f1sh1918 f1sh1918 merged commit 24cc4b1 into main Jun 5, 2024
1 check passed
@f1sh1918 f1sh1918 deleted the 1465-replace-requirements-link branch June 5, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace link inside the digital request form of Bavarian Volunteer Card
2 participants