Fix compilation of martin #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-markl
requested review from
steffenkleinle,
f1sh1918,
ztefanie and
seluianova
as code owners
f1sh1918
reviewed
May 13, 2024
|
No, we don't need this after the martin update. However, we could merge this now until we know how we want to deploy martin in the near future (They distribute their own debian packages via GitHub, so we no longer have to build it here, see also https://git.tuerantuer.org/DF/salt/pulls/155#issuecomment-1364) |
f1sh1918
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This fixes the compilation of martin by upgrading the open ssl dependency while keeping the same version of martin. (I don't exactly know why this began to fail, though)
Proposed changes
While this fixes the compilation error short term, we should still upgrade Martin middle-term :)
Side effects
Likely none, except that we can build martin again.
Resolved issues
Fixes: #1439