-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1333: Add activation route #1334
Conversation
2f508e1
to
75cbac1
Compare
75cbac1
to
d70a474
Compare
administration/src/mui-modules/activation/components/ActivationPageContent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to test this, but it did not work, or I did something wrong.
What I did:
- Created a card
- opened http://localhost:3000/activation/AtIEThFmwAN49h0rWeIwBcB1JoS7gTkn7zJ9UFp8pSU=
The string in the end, is the activation code that is shown below of the qr code on the pdf.
When the activation code does not contain a e.g. slash, i got this error messageDer von Ihnen geöffnete Link ist ungültig. Der Link wurde fehlerhaft in den Browser übertragen. Versuchen Sie, den Link manuell aus der E-Mail oder dem PDF zu kopieren.
when it does contain a slash, i was just redirected to the login page.
Sorry I forgot to mention Until i tested michis comments, i'm gonna revert the pr to draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not test it
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
@ztefanie i would appreciate a second review since michael did not test it. thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it on Android emulator.
I get this as the first screen wenn opening http://localhost:3000/activation/code#ChQKBHRlc3QQoqMBGggKAggBIgIIABIQIuF4botoitZxNY86gioBKxoUJPaMJ8zLarOKBYaIDlfvjFLw0fU=
After clicking on bayern, i see the screen i would have expected. But i think this first screen should not be displayed.
When opening in the browser (on my linux machine) it get:
First screen:
second screen:
This screen is dev only and we need it to decide which project config should be used because we have no proper URL. So this is fine @ztefanie |
Short description
An activation page is needed to handle opening activation links without the app being installed on the smartphone.
Remind the user that the app has to be installed before the card can be activated.
Proposed changes
ProjectSwitcher
component for dev issues (make it reusable)Fixes: #1333
Testing
a) dev environment
http://<networkip>:3000/activation/code#activationCode/
(use the activation code in the console)There is no real good way to test it on dev environment unfortunately, because we need a
localhost/localNetworkIp
link to open the route locally. There also might be issues thatconnection is lost
in the flutter app meanwhile you are in the browser and follow instructions. But this can only happen on dev environments (app in background).b) staging