Fix cicd install bundler #1330
Merged
Fix cicd install bundler #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztefanie
force-pushed
the
fix-ci-bundle-install
branch
from
114c43b
to
9f21ca5
Compare
…tlementcard into fix-ci-bundle-install
ztefanie
force-pushed
the
fix-ci-bundle-install
branch
from
270b69c
to
c84f926
Compare
ztefanie
force-pushed
the
fix-ci-bundle-install
branch
from
995532b
to
017f2ec
Compare
…tlementcard into fix-ci-bundle-install
…tlementcard into fix-ci-bundle-install
…tlementcard into fix-ci-bundle-install
ztefanie
force-pushed
the
fix-ci-bundle-install
branch
from
bb98b90
to
ac147ba
Compare
ztefanie
force-pushed
the
fix-ci-bundle-install
branch
from
ac147ba
to
ece3b90
Compare
ztefanie
requested review from
steffenkleinle,
sarahsporck and
f1sh1918
as code owners
f1sh1918
reviewed
Mar 5, 2024
|
|
||
| - run: | ||
| command: | | ||
| app-toolbelt v0 notify mattermost --message "<< parameters.success_message >>" --channel << parameters.channel >> <<#parameters.allow-all-branches>>--allow-all-branches<</parameters.allow-all-branches>> |
There was a problem hiding this comment.
is this "#" correct here? #parameters.allow-all-branches
Sorry could mark the correct line. its in the next line
There was a problem hiding this comment.
yes it is correct, this is some circleci magic syntax to add the content between the both << >> if the parameter is true.
There was a problem hiding this comment.
yes i know. but i'm talking about the additional # what does that mean.
Update: ah is this an 'open' tag?
f1sh1918
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
delivery is failing due to wrong permissions while installing the gems, see here: https://app.circleci.com/pipelines/github/digitalfabrik/entitlementcard/4572/workflows/75290bc2-3332-49b1-8762-74c3ea5ab9e9/jobs/35497
Proposed changes