Add PR locking configuration at the digger.yml level

[evanstachowiak]

Following the conversation here https://diggertalk.slack.com/archives/C01DVJRK6CX/p1718200181031169.

Adding the ability to enable/disable PR locking in GitHub with a digger.yml config setting.

Addresses this issue: #1577

[motatoes]

Thanks for this. Overall looks good and I'm happy about the naming.

We also need to override locking to be noopLock if this flag is set for backendless mode here:

digger/cli/pkg/github/github.go

Line 214 in 1d611b4

diggerConfig, diggerConfigYaml, dependencyGraph, err := digger_config.LoadDiggerConfig("./", true, nil)

[motatoes]

you need to use the config object here:

Suggested change

	if dg_configuration.PrLocks{
	if config.PrLocks{

[motatoes]

you need to do the same if statement in the handleIssueComment webhook handler in the same file

[evanstachowiak]

I added support for Enable on the struct level, I couldn't see a better way to do it for the cli. In this case I could probably also remove these if statements around the for loops, but it would also save some processing to leave them in.

[motatoes]

Hey @evanstachowiak this looks great, thanks! I would rather not have a flag on the PrLock interface. We have a NoopLock interface implemented here:

digger/libs/locking/locking.go

Line 36 in e43db33

type NoOpLock struct {

which will ignore any lock operations

so if you had something like

if config.Prlocks {
    log.Printf("info: using NoopLock)
    lock = NoopLock{}
}

here it will do the trick - since that path is outside of the orchestrator path.

[motatoes]

@evanstachowiak actually thinking about it again, your changes will work well, the enable flag works. Future refactoring can be done but this is good enough for now!