Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid exception in Nodejs 9 #131

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Avoid exception in Nodejs 9 #131

merged 1 commit into from
Nov 20, 2017

Conversation

tsauzeau
Copy link
Contributor

More info here: nodejs/node#16778

@coveralls
Copy link

coveralls commented Nov 20, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 8d9f8d7 on tsauzeau:bug/fix-crypto-node9 into f832190 on diegohaz:master.

@maustand
Copy link
Collaborator

HI @tsauzeau
Firstly, thank you for your Pull Request.

I am using Nodejs 8.9.1 and i did not have any problems with the generator.
Anyway i will merge this..
Thank you so munch !

@maustand maustand merged commit 5d6cc18 into diegohaz:master Nov 20, 2017
@tsauzeau
Copy link
Contributor Author

tsauzeau commented Nov 20, 2017 •
edited
Loading

Thanks for your generator ;)
Nodejs 9 is distributed since the 1 of November on Archlinux, I just discovered the bug this morning (but it was an easy fix).

@maustand maustand mentioned this pull request Dec 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsauzeau @coveralls @maustand