Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cashier: warning when clicking on default channel #181

Closed
rickysang opened this issue Aug 8, 2018 · 0 comments
Closed

Cashier: warning when clicking on default channel #181

rickysang opened this issue Aug 8, 2018 · 0 comments
Labels
bug Something isn't working @Components Components related P0 Highest priority

Comments

@rickysang
Copy link

Mand Mobile Version

v1.5.2

OS Version & Browser Version

Win10
Chrome Version 67.0.3396.99

Recurring Links

<md-cashier
  v-model="showCashier"
  :channels="paymentChannels"
  :default-index="0"
  payment-amount="$10.00"
  @pay="handleCashierPay"
/>

Recurring Steps

  1. Open cashier
  2. Click on default selected channel

Expectant Behaviors

No warning.

Actual Behaviors

image

I took a look at the code, defaultIndex should be passed to $_onChannelItemClick handler.

Attached source code here:

<ul class="choose-channel-list" v-else-if="channels[defaultIndex]">
  <li class="choose-channel-item default" @click="$_onChannelItemClick(channels[defaultIndex], index)">
    <i class="item-icon" :class="channels[defaultIndex].icon">
      <md-icon :name="channels[defaultIndex].icon"></md-icon>
    </i>
    <span class="item-label" v-html="channels[defaultIndex].text || channels[defaultIndex].label"></span>
    <md-icon
      v-if="!isSingle"
      name="circle-right"
      class="item-check"
    ></md-icon>
  </li>
</ul>
@xxyan0205 xxyan0205 added bug Something isn't working P0 Highest priority labels Aug 8, 2018
@moyus moyus closed this as completed Aug 13, 2018
@xxyan0205 xxyan0205 added the @Components Components related label Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @Components Components related P0 Highest priority
Projects
None yet
Development

No branches or pull requests

3 participants