Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read-index-after-write test case. #28

Merged
merged 2 commits into from
Dec 19, 2018

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Dec 13, 2018

This test case to read-index-after-write within the same txn is no longer valid. See dgraph-io/dgraph#2678


This change is Reviewable

This test case to read-index-after-write within the same txn is no longer valid. See dgraph-io/dgraph#2678
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @paulftw)

@martinmr
Copy link
Contributor

Just merged PR #29 so if you rebase the CI tests should run now.

@danielmai
Copy link
Contributor Author

Thanks, @martinmr!

@danielmai danielmai merged commit d6dd879 into master Dec 19, 2018
@danielmai danielmai deleted the danielmai/fix-read-index-after-write-test branch December 19, 2018 19:25
martinmr pushed a commit that referenced this pull request Dec 20, 2018
This test case to read-index-after-write within the same txn is no longer valid. See dgraph-io/dgraph#2678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants