Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for queries with @recurse and expand(_all_). #3179

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Mar 19, 2019

Currently this type of queries might result in an unrecoverable error
in the alpha. This happens for example, while trying to expand on a node
of type PASSWORD.

The reason is that handleValuePostings and handleUidPostings sometimes
successfully return early without setting the UidMatrix field.

This change adds a fix and modifies the existing test to trigger this
case. I have verified that the test crashes the alpha when the fix is
absent.

Fixes #3161


This change is Reviewable

Currently this type of queries might result in an unrecoverable error
in the alpha. This happens for example, while trying to expand on a node
of type PASSWORD.

The reason is that handleValuePostings and handleUidPostings sometimes
successfully return early without setting the UidMatrix field.

This change adds a fix and modifies the existing test to trigger this
case. I have verified that the test crashes the alpha when the fix is
absent.
@martinmr martinmr requested a review from a team March 19, 2019 22:48
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Just make sure nothing breaks. Add some recursive expand queries in tests.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@martinmr martinmr merged commit 3081fc1 into master Mar 20, 2019
@martinmr martinmr deleted the martinmr/recurse-all-password branch March 20, 2019 22:53
danielmai pushed a commit that referenced this pull request Apr 12, 2019
Currently this type of queries might result in an unrecoverable error
in the alpha. This happens for example, while trying to expand on a node
of type PASSWORD.

The reason is that handleValuePostings and handleUidPostings sometimes
successfully return early without setting the UidMatrix field.

This change adds a fix and modifies the existing test to trigger this
case. I have verified that the test crashes the alpha when the fix is
absent.

(cherry picked from commit 3081fc1)
- Removed common_test.go conflict
- Removed sg.UnknownAttr check that's only in master.
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
Currently this type of queries might result in an unrecoverable error
in the alpha. This happens for example, while trying to expand on a node
of type PASSWORD.

The reason is that handleValuePostings and handleUidPostings sometimes
successfully return early without setting the UidMatrix field.

This change adds a fix and modifies the existing test to trigger this
case. I have verified that the test crashes the alpha when the fix is
absent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

DGraph crash: Whilst using recursive.
2 participants