Print the Dgraph version when running live or bulk loader. #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrjain
reviewed
Nov 8, 2018
manishrjain
suggested changes
Nov 10, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @danielmai)
dgraph/cmd/bulk/run.go, line 73 at r1 (raw file):
Previously, danielmai (Daniel Mai) wrote…
Isn't the version all the same across all the subcommands, though?
Yes. But, they could have been running an older version of Dgraph zero on their server and upgraded the binary on their desktop.
danielmai
commented
Nov 10, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @manishrjain)
dgraph/cmd/bulk/run.go, line 73 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Yes. But, they could have been running an older version of Dgraph zero on their server and upgraded the binary on their desktop.
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to e2783d6.
Would be useful to know when users are sharing their logs from the live or bulk loader.
This change is