feat(dre): Add support for forum post links for version elect proposals #942
+50
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaMilosa
approved these changes
Sep 20, 2024
| self.force, | ||
| ctx.forum_post_link(), | ||
| self.ignore_missing_urls, | ||
| ctx.forum_post_link().expect("Forum post link is required for this proposal"), |
There was a problem hiding this comment.
Can this go in validate step for this Command? It will then use clap abstractions for exiting
There was a problem hiding this comment.
I wanted to have that, yes. But validate does not have access to the command, only to ctx, and the refactor to get the into the validate isn't quite straightforward. But I do feel we should make that change, so I agree with you.
| self.force, | ||
| ctx.forum_post_link(), | ||
| self.ignore_missing_urls, | ||
| ctx.forum_post_link().expect("Forum post link is required for this proposal"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.