fix(dre): adding back output of proposals #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back the output of ic admin propose command to stdout in the form of:
./target/debug/dre --private-key-pem ~/.config/dfx/identity/bootstrap-super-leader/identity.pem --network staging -y propose propose-to-revise-elected-guestos-versions --summary "Testing" --replica-versions-to-unelect 26d5f9d0bdca0a817c236134dc9c7317b32c69a5 2024-08-26T12:04:03.234Z INFO dre > Running version 0.5.1-3640baca-dirty 2024-08-26T12:04:03.390Z INFO dre::ic_admin > Using ic-admin c7d517db67fde740f5e3338c86e95b4ec8beb00a because lock file was created less than 24 hours ago Title: Retire IC replica version(s) Summary: Testing Payload: ReviseElectedGuestosVersionsPayload { replica_version_to_elect: None, release_package_sha256_hex: None, release_package_urls: [], guest_launch_measurement_sha256_hex: None, replica_versions_to_unelect: [ "26d5f9d0bdca0a817c236134dc9c7317b32c69a5", ], } +proposal 727Also includes a small fix for revise replica versions command: The arguments changed.