Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): Release rc--2024-07-18_01-30--github #642

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion release-controller/ci_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,10 @@ def check_rc_order(index: ReleaseIndex) -> list[str]:
errors = []
date_format = "%Y-%m-%d_%H-%M"
parsed = [
{"name": release.rc_name, "date": datetime.strptime(release.rc_name.removeprefix("rc--"), date_format)}
{
"name": release.rc_name,
"date": datetime.strptime(release.rc_name.removeprefix("rc--").removesuffix("--github"), date_format),
}
for release in index.releases
]

Expand Down
6 changes: 6 additions & 0 deletions release-index.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
releases:
- rc_name: rc--2024-07-18_01-30--github
versions:
- name: base
# Successful qualification pipeline on IC staging:
# https://gitlab.com/dfinity-lab/core/release/-/jobs/7373028872
version: de29a1a55b589428d173b31cdb8cec0923245657
- rc_name: rc--2024-07-10_23-01
versions:
- name: base
Expand Down
Loading