Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: renaming bazel targets #557

Merged
merged 2 commits into from
Jul 1, 2024
Merged

refactor: renaming bazel targets #557

merged 2 commits into from
Jul 1, 2024

Conversation

NikolaMilosa
Copy link
Contributor

Convenience refactor for easier to use targets.
Previously to import a docker image into local registry we would have to run something like:

bazel run //rs/ic-observability/multiservice-discovery:multiservice-discovery-tarball

Now we can just run:

bazel run //rs/ic-observability/multiservice-discovery:tarball

And the target names are the same across all binaries.

Contains additional upgrade for pylint in pre-commit so that it works in envs with python3.12:
Linked issue: pre-commit/pre-commit#3041

@NikolaMilosa NikolaMilosa requested a review from a team as a code owner July 1, 2024 09:29
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@NikolaMilosa NikolaMilosa merged commit 1d1d034 into main Jul 1, 2024
4 checks passed
@NikolaMilosa NikolaMilosa deleted the nm-refactoring branch July 1, 2024 09:35
@DFINITYManu
Copy link
Contributor

Late for the approval but thank you nonetheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants