Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed DashboardBackendClient from CLI #552

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Removed DashboardBackendClient from CLI #552

merged 6 commits into from
Jun 28, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Jun 28, 2024 •
edited
Loading

  1. Removed Client DashboardBackend from CLI
  2. Removed endpoints: pending_action replace create_subnet resize retireable get_nns_replica_version

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner June 28, 2024 11:43
@pietrodimarco-dfinity pietrodimarco-dfinity changed the title Removed dashboardbackend dependency from CLI Removed DashboardBackendClient from CLI Jun 28, 2024
sasa-tomic
sasa-tomic reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, brilliant! Thank you Pietro!

@pietrodimarco-dfinity pietrodimarco-dfinity merged commit 4cc49d3 into main Jun 28, 2024
4 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the remove-backend-usage-from-cli branch June 28, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasa-tomic sasa-tomic sasa-tomic left review comments

@DFINITYManu DFINITYManu DFINITYManu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pietrodimarco-dfinity @sasa-tomic @DFINITYManu