Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify errors in main() coming from the governance canister client. #232

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

DFINITYManu
Copy link
Contributor

I spent 10 minutes trying to grep for the error, to no avail. When I had to spend another 5 minutes adding panic()s to the code in order to suss this one out, I decided to do something about it.

I spent 10 minutes trying to grep for the error, to no avail.  When I
had to spend another 5 minutes adding `panic()`s to the code in order
to suss this one out, I decided to do something about it.
@DFINITYManu DFINITYManu requested a review from a team as a code owner March 6, 2024 17:56
@DFINITYManu DFINITYManu self-assigned this Mar 6, 2024
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :) THX

Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sasa-tomic sasa-tomic added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit e086a17 Mar 6, 2024
3 checks passed
@sasa-tomic sasa-tomic deleted the clarifyerror branch March 6, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants