Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Remove backend server from CLI) - 01 - Do not use backend server for hostos-rollout cmd CLI #193

Merged
merged 5 commits into from
Feb 27, 2024
Merged

(Remove backend server from CLI) - 01 - Do not use backend server for hostos-rollout cmd CLI #193

merged 5 commits into from
Feb 27, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

This is the first of a series of PRs that aim to remove backend server usage from the CLI code.

  • Migrate hostos_rollout from backend to CLI
  • Refactor code around this change

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner February 14, 2024 12:01
sasa-tomic
sasa-tomic approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 799e840 Feb 27, 2024
3 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the 01-move-hostos-rollout branch February 27, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasa-tomic sasa-tomic sasa-tomic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietrodimarco-dfinity @sasa-tomic