feat(msd): metrics #171
Merged
feat(msd): metrics #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DFINITYManu
requested changes
Feb 8, 2024
There was a problem hiding this comment.
Please fix or verify metrics names are correct (otel may apply some postprocessing to standardize). Stand by for link.
https://prometheus.io/docs/practices/naming/ please follow this standard.
DFINITYManu
requested changes
Feb 8, 2024
This reverts commit 8e74c5c.
…network for easier alert creation
sasa-tomic
approved these changes
Feb 9, 2024
|
MSD Diff
targets.json--- a/home/runner/main-targets/targets.json
+++ b/home/runner/branch-targets/targets.json
@@ -65543,6 +65543,56 @@
"job": "guest_metrics_proxy"
}
},
+ {
+ "targets": [
+ "http://[2001:ab8:1000:f81:6801:4fff:fe8c:5e50]:9091/"
+ ],
+ "labels": {
+ "ic": "mercury",
+ "ic_node": "5cphe-ynceg-ybsv7-5fpo7-rxte2-hbmm6-wkren-7lyfb-nhlls-pu6ow-kae",
+ "job": "orchestrator"
+ }
+ },
+ {
+ "targets": [
+ "https://[2001:ab8:1000:f81:6801:4fff:fe8c:5e50]:9100/metrics"
+ ],
+ "labels": {
+ "ic": "mercury",
+ "ic_node": "5cphe-ynceg-ybsv7-5fpo7-rxte2-hbmm6-wkren-7lyfb-nhlls-pu6ow-kae",
+ "job": "node_exporter"
+ }
+ },
+ {
+ "targets": [
+ "https://[2001:ab8:1000:f81:6800:4fff:fe8c:5e50]:9100/metrics"
+ ],
+ "labels": {
+ "ic": "mercury",
+ "ic_node": "5cphe-ynceg-ybsv7-5fpo7-rxte2-hbmm6-wkren-7lyfb-nhlls-pu6ow-kae",
+ "job": "host_node_exporter"
+ }
+ },
+ {
+ "targets": [
+ "https://[2001:ab8:1000:f81:6800:4fff:fe8c:5e50]:19100/metrics"
+ ],
+ "labels": {
+ "ic": "mercury",
+ "ic_node": "5cphe-ynceg-ybsv7-5fpo7-rxte2-hbmm6-wkren-7lyfb-nhlls-pu6ow-kae",
+ "job": "host_metrics_proxy"
+ }
+ },
+ {
+ "targets": [
+ "https://[2001:ab8:1000:f81:6801:4fff:fe8c:5e50]:19100/metrics"
+ ],
+ "labels": {
+ "ic": "mercury",
+ "ic_node": "5cphe-ynceg-ybsv7-5fpo7-rxte2-hbmm6-wkren-7lyfb-nhlls-pu6ow-kae",
+ "job": "guest_metrics_proxy"
+ }
+ },
{
"targets": [
"http://[2a0f:cd00:2:1:6801:c1ff:fee2:c0f9]:9091/"
|
Hmm this seems to be off. cc @pietrodimarco-dfinity any idea why this diff is non-empty? |
yes @sasa-tomic :) the registry simply got an update! From branch And those targets from 2001:ab8:1000:f81:6800:4fff:fe8c:5e50 have been introduced. nothing to worry about. |
DFINITYManu
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we introduce all axum-otel-metrics alongside 4 custom metrics:
msd_definitions_load_errors_total: number of errors while loading new targets per definition.msd_definitions_load_successful: status metric which indicates if last load was successful (1) or not (0).msd_definitions_sync_errors_total: number of errors while syncing the registry per definition.msd_definitions_sync_successful: status metric which indicates if last scrape was successful (1) or not (0).