Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update num-bigint to v0.4.2 #274

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Conversation

qti3e
Copy link
Contributor

@qti3e qti3e commented Sep 7, 2021

Overview

The compilation is broken on nightly, due to:
rust-lang/rust#88581
This commit upgrades the num-bigint package to v0.4.2 which resolves this issue:
rust-num/num-bigint#219

Requirements

A new minor version of candid should be released with the dependency upgrade and used across the different crates including the ic_cdk.

Considered Solutions
Updating the dependency

Recommended Solution

Considerations
No breaking change is introduced.

The compilation is broken on nightly, due to:
rust-lang/rust#88581
This commit upgrades the num-bigint package to v0.4.2 which resolves this issue:
rust-num/num-bigint#219
@chenyan-dfinity chenyan-dfinity merged commit 165f856 into dfinity:master Sep 7, 2021
ninegua pushed a commit to ninegua/candid that referenced this pull request Apr 22, 2022
* docs: simplify the sample-javascript

Remove authClient and move everything into 3 functions; login, logout and handleCallback.
The goal is to move the login and handleCallback in the authentication package
and be the low level API. Even lower than that, login will most likely be
createRequestUrl() or something to that effect, and leave the navigation to the
application layer.

* .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants