Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[authproxy] add cusom header and group configuration documentation #109

Merged
merged 1 commit into from
Mar 30, 2022
Merged

[authproxy] add cusom header and group configuration documentation #109

merged 1 commit into from
Mar 30, 2022

Conversation

seuf
Copy link
Contributor

@seuf seuf commented Jan 31, 2022 •
edited
Loading

Update authproxy documentation with configurable headers and staticGroups.

See : dexidp/dex#2371

@seuf seuf mentioned this pull request Jan 31, 2022
Merged
@seuf seuf force-pushed the authproxy-groups-documentation branch 2 times, most recently from d8f9e6d to 7dd7ddf Compare January 31, 2022 10:23
@nabokihms
Copy link
Member

@nate-double-u, could you please check this PR when you have time? This is a doc for the new feature.

@nate-double-u
Copy link
Contributor

I think I can take a look at this on Monday 🙂

nate-double-u
nate-double-u approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a copy edit pass.

It looks good to me once the inline comments are resolved.

content/docs/connectors/authproxy.md Outdated Show resolved Hide resolved
content/docs/connectors/authproxy.md Outdated Show resolved Hide resolved
content/docs/connectors/authproxy.md Outdated Show resolved Hide resolved
content/docs/connectors/authproxy.md Outdated Show resolved Hide resolved
content/docs/connectors/authproxy.md Outdated Show resolved Hide resolved
content/docs/connectors/authproxy.md Outdated Show resolved Hide resolved
@nate-double-u
Copy link
Contributor

Thanks for the updates @seuf, unfortunately the GitHub UI doesn't make it obvious that the DCO is still required, even when accepting a suggestion.

To merge this, each commit needs to be signed. https://github.com/dexidp/website/pull/109/checks?check_run_id=5657854026

@seuf
[authproxy] Headers and group configuration documentation
96353c7 
Signed-off-by: seuf <seuf76@gmail.com>
@seuf seuf force-pushed the authproxy-groups-documentation branch from 0421d2c to 96353c7 Compare March 28, 2022 12:04
@seuf
Copy link
Contributor Author

seuf commented Mar 28, 2022

Hello, I've squashed the commits, so we have only one signed commit with all the changes

@nate-double-u
Copy link
Contributor

/lgtm
(from a docs perspective -- I haven't done a technical pass on this tho)

@nabokihms nabokihms self-requested a review March 29, 2022 17:29
@nabokihms
Copy link
Member

@seuf thank you for contributing!

@nabokihms nabokihms merged commit ecf1ae7 into dexidp:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

@nabokihms nabokihms nabokihms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seuf @nabokihms @nate-double-u