server/rotation.go: avoid displaying the "keys already rotated" error #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
reviewed
Apr 11, 2017
| if tNow.Before(keys.NextRotation) { | ||
| return storage.Keys{}, errors.New("keys already rotated") |
There was a problem hiding this comment.
can we have an info level log message here? Maybe explain that another server already rotated it?
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
server/rotation.go: avoid displaying the "keys already rotated" error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #890.
If the user is running multiple instances of dex, it is possible that one instance can rotate the keys before another gets around to doing it. Since this is an acceptable situation, we can avoid logging this as an error.