Cross client refresh tokens #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyrullo
force-pushed
the
cross_client_refresh_tokens
branch
2 times, most recently
from
3e2ac94
to
04e4e2c
Compare
| @@ -147,8 +147,10 @@ func makeUserAPITestFixtures() *userAPITestFixtures { | |||
| } | |||
|
|
|||
| refreshRepo := db.NewRefreshTokenRepo(dbMap) | |||
| fmt.Println("DEFAULT: ", oidc.DefaultScope) | |||
There was a problem hiding this comment.
Leftover print statement?
bobbyrullo
force-pushed
the
cross_client_refresh_tokens
branch
3 times, most recently
from
6e9521d
to
e560aab
Compare
|
lgtm (pending a squash) |
added 2 commits
June 14, 2016 14:14
A refresh request must fail if it asks for scopes that were not originally granted when the refresh token was obtained. This Commit: * changes repo to store scopes with tokens * changes repo interface signatures so that scopes can be stored and verified * updates dependent code to pass along scopes
Before, this logic was only in the OIDCServer.CodeToken() method; now it has been pulled out so that other paths, like OIDCServer.RefreshToken() can use it. The net affect, is that now refresh tokens can be used to get cross-client authenticated ID Tokens.
bobbyrullo
force-pushed
the
cross_client_refresh_tokens
branch
from
e560aab
to
75473b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh clients can now be used to do cross-client auth.