Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gomplate 4.0.1 #3652

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Bump gomplate 4.0.1 #3652

merged 1 commit into from
Jul 30, 2024

Conversation

MoeBensu
Copy link
Contributor

Overview

What this PR does / why we need it

Fixes #3632 by bumping gomplate from v3.11.8 to v4.0.0

Special notes for your reviewer

This is breaking change bump in gomplate and requires testing. This is just a suggestion from me to fix the CVE. The local setup is not working well in my machine and I can't find the right docs to pursue that further, therefore I will set it to draft till tested by somebody else.

@nabokihms nabokihms changed the title Bump; gomplate 4.0.0 Bump gomplate 4.0.0 Jul 26, 2024
Dockerfile Outdated Show resolved Hide resolved
@nabokihms
Copy link
Member

The number of breaking changes and deprecations really blows my mind.

@sagikazarmark I think it starts to get boring updating complete every time CVE is found in go runtime. Maybe we can come back and discuss dex config and its templating once again.

@MoeBensu MoeBensu changed the title Bump gomplate 4.0.0 Bump gomplate 4.0.1 Jul 28, 2024
@nabokihms nabokihms marked this pull request as ready for review July 29, 2024 17:52
@nabokihms nabokihms merged commit 270023b into dexidp:master Jul 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2024-24790
2 participants