Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also set the username in authproxy connector #3307

Merged

Conversation

ppacher
Copy link
Contributor

@ppacher ppacher commented Jan 26, 2024

Overview

The authproxy connector only sets the preferred_username but not username. This causes issues with some OIDC clients that don't fallback to preferred_username.

One example here is rallly but I also noticed that there's no username when using dex with WikiJS.

What this PR does / why we need it

In addition to preferred_username, the authproxy connector now also set's the Username field on the connector.Identity

Update tests

Signed-off-by: Patrick Pacher <patrick.pacher@gmail.com>
Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppacher good catch! No objections to merge.

@nabokihms nabokihms merged commit 8e07edc into dexidp:master Jan 26, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants