Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to storage's Create endpoints #2935

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

PumpkinSeed
Copy link
Contributor

Overview

This PR introduce the context for the storage interface's Create endpoints.

What this PR does / why we need it

Resolves part of the #2132

Special notes for your reviewer

NONE

Does this PR introduce a user-facing change?

NONE

- Add context.Context to Storage interface's Create endpoints

Signed-off-by: PumpkinSeed <qwer.kocka@gmail.com>
Signed-off-by: PumpkinSeed <qwer.kocka@gmail.com>
Signed-off-by: PumpkinSeed <qwer.kocka@gmail.com>
Signed-off-by: PumpkinSeed <qwer.kocka@gmail.com>
Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one, @PumpkinSeed. We are about to release the new version of Dex v2.37, and this change is only a part of the big improvement. If you don't mind, I'd like to mark this PR for the upcoming release v2.38.

@nabokihms nabokihms added this to the v2.38.0 milestone May 18, 2023
@nabokihms
Copy link
Member

@PumpkinSeed, sorry for the long delay. Could you please rebase the branch so we can merge it?

@sagikazarmark sagikazarmark merged commit 2377b0a into dexidp:master Jan 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants