correctly handle path escaping for connector IDs #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
|
@nabokihms any update on the release date for this? I appreciate any help in nudging this along. TIA! |
nabokihms
reviewed
Nov 11, 2021
|
As far as I can tell there are changes requested, so moving to next release. |
|
@bobcallaway @nabokihms any update about the status of this PR? From what I can tell there is a debate about the implementation. |
|
We can still accept the current implementation. The debate is about details o internal component implementation and only about cosmetics. @bobcallaway, I think we can accept this PR as is, yet rebasing the branch is still required. |
|
ok, i will rebase it then |
nabokihms
approved these changes
May 31, 2022
nabokihms
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2289
Signed-off-by: Bob Callaway bob.callaway@gmail.com
Overview
What this PR does / why we need it
Special notes for your reviewer
Does this PR introduce a user-facing change?