[doc/example] Make LDAP example functional again by running OpenLDAP with docker-compose #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heidemn-faro
changed the title
heidemn-faro
force-pushed
the
doc/ldap-example
branch
from
aea5bfb
to
b4d22bf
Compare
…ocker Signed-off-by: Martin Heide <martin.heide@faro.com>
Signed-off-by: Martin Heide <martin.heide@faro.com>
heidemn-faro
commented
Jul 13, 2020
| @@ -11,7 +11,7 @@ connectors: | |||
| name: OpenLDAP | |||
| id: ldap | |||
| config: | |||
| host: localhost:10389 | |||
| host: localhost:389 | |||
There was a problem hiding this comment.
If there's a strong opinion to use the nonstandard port, I can revert it.
But then the port would be different here (outside the container) and when using "docker exec" (inside the container).
There was a problem hiding this comment.
I think the rationale behind using a non-standard port is avoiding potential collision with an existing service. But all the other examples (mysql, etc) use standard ports, so it should be okay.
heidemn-faro
changed the title
|
Thanks @heidemn-faro . Personally, I'd much rather see a docker-compose based solution, without adding back that script. I believe the OpenLDAP image is able to add definitions automatically on startup. |
heidemn-faro
force-pushed
the
doc/ldap-example
branch
3 times, most recently
from
d52d592
to
521954a
Compare
Signed-off-by: Martin Heide <martin.heide@faro.com>
Signed-off-by: Martin Heide <martin.heide@faro.com>
heidemn-faro
changed the title
|
@sagikazarmark as requested, I've reworked this to use docker-compose. |
sagikazarmark
approved these changes
Jul 15, 2020
|
@sagikazarmark @bonifaido thanks for reviewing. I don't have permissions to merge, so you would have to do that. |
xtremerui
pushed a commit
to concourse/dex
that referenced
this pull request
Oct 5, 2020
The official docker release for this release can be pulled from
dexidp/dex:v2.25.0
**Features:**
- Move the API package to a separate module (dexidp#1741, @sagikazarmark)
- OAuth2 Device Authorization Grant (dexidp#1706, @justin-slowik)
- Support username, email and groups claim in OIDC connector (dexidp#1634, @xtremerui)
**Bugfixes:**
- Add offline_access scope in microsoft connector, if required (dexidp#1441, @jimmythedog)
- Allow the google connector to work without a service account (dexidp#1720, @candlerb)
**Minor changes:**
- Remove vendor (finally) (dexidp#1745, @sagikazarmark)
- Fix the LDAP example (dexidp#1762, @heidemn-faro)
- Relocate the example app (dexidp#1764, @sagikazarmark)
xtremerui
pushed a commit
to concourse/dex
that referenced
this pull request
Nov 5, 2020
The official docker release for this release can be pulled from
dexidp/dex:v2.25.0
**Features:**
- Move the API package to a separate module (dexidp#1741, @sagikazarmark)
- OAuth2 Device Authorization Grant (dexidp#1706, @justin-slowik)
- Support username, email and groups claim in OIDC connector (dexidp#1634, @xtremerui)
**Bugfixes:**
- Add offline_access scope in microsoft connector, if required (dexidp#1441, @jimmythedog)
- Allow the google connector to work without a service account (dexidp#1720, @candlerb)
**Minor changes:**
- Remove vendor (finally) (dexidp#1745, @sagikazarmark)
- Fix the LDAP example (dexidp#1762, @heidemn-faro)
- Relocate the example app (dexidp#1764, @sagikazarmark)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1654