Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Active Directory and kubelogin integration sample. #1390

Merged
merged 4 commits into from
Feb 3, 2019

Conversation

okamototk
Copy link
Contributor

This PR includes Active Directory and kubelogin integration sample.

@ericchiang
Copy link
Contributor

Would you mind adding instructions here for how to use this? https://github.com/dexidp/dex/blob/master/Documentation/connectors/ldap.md#getting-started

@srenatus srenatus changed the title Add Active Directory and kubeloing integration sample. Add Active Directory and kubelogin integration sample. Jan 26, 2019
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some comments and nitpicks.

Documentation/connectors/kubelogin-activedirectory.md Outdated Show resolved Hide resolved
Documentation/connectors/ldap.md Outdated Show resolved Hide resolved
Documentation/connectors/kubelogin-activedirectory.md Outdated Show resolved Hide resolved
Documentation/connectors/kubelogin-activedirectory.md Outdated Show resolved Hide resolved
Documentation/connectors/kubelogin-activedirectory.md Outdated Show resolved Hide resolved
Documentation/connectors/kubelogin-activedirectory.md Outdated Show resolved Hide resolved
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. 🎈

@srenatus srenatus merged commit b6f4740 into dexidp:master Feb 3, 2019
mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019
Add Active Directory and kubelogin integration sample.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants