Kubernetes docs: clarify steps around use/creation of TLS assets. #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got my issue numbers wrong, embarassing |
srenatus
approved these changes
Nov 22, 2018
added 3 commits
November 23, 2018 10:48
…ifest, remove some references to deprecated TPR approach
|
Thanks for the fast review! I've updated (sorry) with some of the follow-ups I mentioned above |
srenatus
approved these changes
Nov 23, 2018
| @@ -262,7 +262,7 @@ connectors: | |||
| # freeIPA server's CA | |||
| rootCA: ca.crt | |||
| userSearch: | |||
| # Would translate to the query "(&(objectClass=person)(uid=<username>))". | |||
| # Would translate to the query "(&(objectClass=posixAccount)(uid=<username>))". | |||
|
Looks good to me. However, I have no idea if it's correct. Please bear with me, let's get someone with sufficient knowledge of the domain to review this. (If you know someone, feel free to pull them in, it doesn't have to be someone with "commit bit". I'll merge when this has been reviewed, then.) |
|
That sounds good to me, I'm not sure who to call on as this is all based on my own testing but I'd definitely appreciate a second set of eyes. |
|
@whereisaaron @rendhalver would this be something one of you could weigh in on at all? |
|
Nice work! |
OwenTuz
deleted the
issue-1132-initial-kubernetes-documentation-improvements
branch
|
Good update |
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
…etes-documentation-improvements Kubernetes docs: clarify steps around use/creation of TLS assets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #1262 .
While not strictly related to TLS, I'd like to make one or more follow-up PRs to fix issues around old references to TPRs, missing instructions on creating the serviceAccount and roles for RBAC etc. But this is a first pass, hopefully it makes reviewing easier.