-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postgres: expose database/sql tunables #1357
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
// +build go1.11 | ||
|
||
package sql | ||
|
||
import ( | ||
"os" | ||
"testing" | ||
) | ||
|
||
func TestPostgresTunables(t *testing.T) { | ||
host := os.Getenv(testPostgresEnv) | ||
if host == "" { | ||
t.Skipf("test environment variable %q not set, skipping", testPostgresEnv) | ||
} | ||
baseCfg := &Postgres{ | ||
Database: getenv("DEX_POSTGRES_DATABASE", "postgres"), | ||
User: getenv("DEX_POSTGRES_USER", "postgres"), | ||
Password: getenv("DEX_POSTGRES_PASSWORD", "postgres"), | ||
Host: host, | ||
SSL: PostgresSSL{ | ||
Mode: sslDisable, // Postgres container doesn't support SSL. | ||
}} | ||
|
||
t.Run("with nothing set, uses defaults", func(t *testing.T) { | ||
cfg := *baseCfg | ||
c, err := cfg.open(logger, cfg.createDataSourceName()) | ||
if err != nil { | ||
t.Fatalf("error opening connector: %s", err.Error()) | ||
} | ||
defer c.db.Close() | ||
if m := c.db.Stats().MaxOpenConnections; m != 5 { | ||
t.Errorf("expected MaxOpenConnections to have its default (5), got %d", m) | ||
} | ||
}) | ||
|
||
t.Run("with something set, uses that", func(t *testing.T) { | ||
cfg := *baseCfg | ||
cfg.MaxOpenConns = 101 | ||
c, err := cfg.open(logger, cfg.createDataSourceName()) | ||
if err != nil { | ||
t.Fatalf("error opening connector: %s", err.Error()) | ||
} | ||
defer c.db.Close() | ||
if m := c.db.Stats().MaxOpenConnections; m != 101 { | ||
t.Errorf("expected MaxOpenConnections to be set to 101, got %d", m) | ||
} | ||
}) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When would it be appropriate to set these to a higher value? (about how many clients?) What's the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The defaults right now should be zeros, which is the same as the stdlib default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realised I hadn't answered your question at all there, but it was time to go to bed. I'll update the issue #1354 with some details, as I'd think that's what people might find first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include defaults here that we feel are reasonable values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 sure. I'm not sure what makes for good defaults, but I can try 😅