*: run kubernetes tests in travis #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to add a note here https://github.com/coreos/dex/blob/master/Documentation/dev-integration-tests.md mentioning that we have added these tests to travis? |
ericchiang
commented
Oct 31, 2017
storage/kubernetes/storage.go
Outdated
| return nil | ||
| } | ||
| } | ||
| return fmt.Errorf("crd %s not ready", err) |
There was a problem hiding this comment.
woops, needs to be "name"
|
@rithujohn191 ready for review |
scripts/test-k8s.sh
Outdated
| printf '.' | ||
| sleep 1 | ||
| done | ||
| echo "ok" |
There was a problem hiding this comment.
maybe we could print out a more meaningful message here.
There was a problem hiding this comment.
Yeah, changed to "API server ready"
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
*: run kubernetes tests in travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an experiment for now