storage/static.go: storage backend should not explicitly lower-case email ids.

[rithujohn191]

No description provided.

[ericchiang]

can you add a test and add a docstring to the passwordsByEmail field?

[ericchiang]

:=

[rithujohn191]

added a test and documentation

[ericchiang]

Need to read this value back an ensure the emails match.

[rithujohn191]

This test makes sure that "Spam@example.com" cannot be created, so it ensures an error is returned

[rithujohn191]

do you want me to check if "spam@example.com" gets created with the all lower case?

[ericchiang]

Something like

p, err := s.GetPassword(strings.ToLower(p4.Email))

p.Email == p4.Email

[rithujohn191]

done

[kans]

Could we log or something if the lowered email as already in the map?

[ericchiang]

We would just return an error here. @rithujohn191 what do you think?

[ericchiang]

Actually I only think we can log this error. Erroring out would be backward incompatible, if sensible :(

[rithujohn191]

So if we don't error out we essentially allow the user to overwrite the map. For the following ConfigMap:

staticPasswords:
- email: "admin@example.com"
  # bcrypt hash of the string "password"
  hash: "$2a$10$2b2cU8CPhOTaGrs1HRQuAueS7JTT5ZHsHSzYiFPm1leZck7Mc8T4W"
  username: "admin"
  userID: "08a8684b-db88-4b73-90a9-3cd1661f5466"
- email: "Admin@example.com"
  # bcrypt hash of the string "password"
  hash: "$2a$10$2b2cU8CPhOTaGrs1HRQuAueS7JTT5ZHsHSzYiFPm1leZck7Mc8T4W"
  username: "Admin"
  userID: "08a8684b-db88-4b73-90a9-3cd1661f5466"

Only the second password gets registered. And then if the user tries to login with the first email it still succeed but returns the wrong email id in the claims:

"email": "Admin@example.com",

That's not desirable behavior :(

[ericchiang]

@rithujohn191 right, but prior to this that config would not have errored, if we error now we might break someone during a dex upgrade.

[rithujohn191]

logged the error

[rithujohn191]

working on adding the logger

[rithujohn191]

Done :)

[ericchiang]

lgtm