Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix broken links #800

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Conversation

PrajwalBorkar
Copy link
Contributor

Signed-off-by: Prajwal Borkar prajwalborkar5075@gmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Fixed these links in files -
file:///home/runner/work/devstream/devstream/site/core-concepts/core-concepts/images/architecture-overview.png
file:///home/runner/work/devstream/devstream/site/development/architecture.zh/development/creating-a-plugin.md
file:///home/runner/work/devstream/devstream/site/README_zh/CODE_OF_CONDUCT.md

Remaining links are either working or unable to find links.

Related Issues

Fixes #799

New Behavior (screenshots if needed)

Signed-off-by: Prajwal Borkar <prajwalborkar5075@gmail.com>
Copy link
Member

@aFlyBird0 aFlyBird0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. 🙌

@aFlyBird0
Copy link
Member

Hi @PrajwalBorkar , thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack!
Here are a few useful things for you to continue your open-source journey:

@aFlyBird0
Copy link
Member

By the way, maybe you have noticed that the CI check lint commit message failed. And there is the reason. @PrajwalBorkar

image

You don't need to edit this commit. We will help you do that. Just be aware of it the next time you commit.

Thanks again for your contribution! I will continue to fix the other links after your work.

@PrajwalBorkar
Copy link
Contributor Author

By the way, maybe you have noticed that the CI check lint commit message failed. And there is the reason. @PrajwalBorkar

image

You don't need to edit this commit. We will help you do that. Just be aware of it the next time you commit.

Thanks again for your contribution! I will continue to fix the other links after your work.

What changes are to be made to resolve the error? Also the remaining links I'm unable to find if you found then paste them here.

@aFlyBird0
Copy link
Member

By the way, maybe you have noticed that the CI check lint commit message failed. And there is the reason. @PrajwalBorkar
image
You don't need to edit this commit. We will help you do that. Just be aware of it the next time you commit.
Thanks again for your contribution! I will continue to fix the other links after your work.

What changes are to be made to resolve the error? Also the remaining links I'm unable to find if you found then paste them here.

You don't need to do anything else in this pr. Just join our slack channel and read the docs of DevStream if you are interested in. Thank you for you contribution.

For this error: this error is reported by "lint commit message check" CI. @IronCore864 will help you fix this error when he merges this pr. You need not to do anything.

( just remerber, do not use upper case in commit messages next time ❤️)

@IronCore864 IronCore864 merged commit d408734 into devstream-io:main Jul 4, 2022
@PrajwalBorkar PrajwalBorkar deleted the prajwal-patch branch July 4, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📖 Docs: Fix broken links
3 participants